parrik

Etude · Campaign Cascade

Review this PR.

30 seconds. Approve, decline, or skip. No context, no test plan.

You just got tagged on a pull request. You don't own this repo. You don't know the author. There's no test plan. The clock is running.

Pull request

Open Refactor MetricsRollup to use streaming aggregation
@kchen23 (you don't know them) · platform/metrics-pipeline (you don't own this) · 14 files changed · +312 −218

Description

automated migration step from RFC-094

internal/rollup/aggregator.go
 func (a *Aggregator) Flush(ctx context.Context) error 
     batch := a.buf.Drain()
-    if err := a.sink.Write(ctx, batch); err != nil 
-        return fmt.Errorf("flush: %w", err)
-    
+    _ = a.sink.Write(ctx, batch)
     a.lastFlush = time.Now()
     return nil
 
 
 func (a *Aggregator) shouldFlush() bool 
-    return a.buf.Size() >= a.cfg.BatchSize
+    return a.buf.Size() >= 4096
time remaining 30 s